this depends on how much price you wish to trade. For Medium and large money trader, its Share khan, etc
For those, who want to play with 50K-1lac and long term investor, ICICI direct is good.
For Day trading and all, have to choose based on own exp, as each has its own advantage
Compare brokerage based on your trade money